Remove unused @mdn/browser-compat-data dependency#686
Open
TomiBelan wants to merge 1 commit intoamilajack:mainfrom
Open
Remove unused @mdn/browser-compat-data dependency#686TomiBelan wants to merge 1 commit intoamilajack:mainfrom
TomiBelan wants to merge 1 commit intoamilajack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-compat does not use @mdn/browser-compat-data at all. Its only usage throughout history was added in fa15cc6 and removed in e8e4d62. And that was just for a type declaration.
It also wastes node_modules disk space. eslint-plugin-compat depends on ast-metadata-inferer which currently depends on @mdn/browser-compat-data
^5.6.19. But eslint-plugin-compat also directly depends on @mdn/browser-compat-data^6.1.1. They have different major versions, so both are wastefully installed side by side.The contrast with PR #682 is ironic. :) Please merge that one too btw.